cullmann closed this revision.
cullmann added a comment.
Git commit e1c3d16a35ddae90de6e457a31f54d899abb84c8 by Christoph Cullmann, on
behalf of Nibaldo González.
Committed on 15/08/2018 at 18:22.
Pushed by cullmann into branch 'master'.
Modelines: add byte-order-mark & small fixes
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Works, will integrate, thanks for the patch!
REPOSITORY
R216 Syntax Highlighting
BRANCH
arcpatch-D14274
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov,
cullmann added a comment.
Will try that out again.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking,
nibags updated this revision to Diff 39789.
nibags added a comment.
- Fix test (use Modelines in Python instead of Bash)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14274?vs=39717=39789
BRANCH
arcpatch-D14274
REVISION DETAIL
cullmann requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh,
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I needed to revert this again, as we get tests failures:
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bffb66cb3ed8: Modelines: add byte-order-mark small
fixes (authored by nibags, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
OK, thanks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
arcpatch-D14274
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
nibags updated this revision to Diff 39552.
nibags added a comment.
- Corrects references erroneously included in previous update
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14274?vs=39551=39552
BRANCH
arcpatch-D14274
REVISION DETAIL
nibags updated this revision to Diff 39551.
nibags added a comment.
- Add test & add DetectSpace.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14274?vs=38477=39551
BRANCH
fix-modelines
REVISION DETAIL
https://phabricator.kde.org/D14274
nibags added a comment.
I will update the diff including the tests.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,
nibags added a comment.
So I keep the DetectSpaces rule and only delete the LineContinue.
By having a file with Modelines as a test, randomly, different .html and .ref
files are generated each time I run "testhighlighter_test" and
"htmlhighlighter_test". That is, sometimes the .html and
dhaumann added a comment.
Sidenote: Looking into the code in KTextEditor, there is:
} else if (var == QLatin1String("bom") || var ==
QLatin1String("byte-order-mark") || var == QLatin1String("byte-order-marker")) {
if (checkBoolValue(val, )) {
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
is only a performance optimization, as it just skips over
whitespaces before any of the costly rules are tried to match. I think that
should just be added again.
nibags updated this revision to Diff 38477.
nibags added a comment.
- Delete update references
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14274?vs=38201=38477
BRANCH
fix-modelines
REVISION DETAIL
https://phabricator.kde.org/D14274
nibags edited the summary of this revision.
nibags added reviewers: turbov, dhaumann, cullmann, vkrause, Kate.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14274
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel,
nibags created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
Changes:
- Add missing keyword: `byte-order-mark` (there is only
17 matches
Mail list logo
