D14275: Add Autodesk EAGLE sch and brd file format to the XML category

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Git commit 106694b84c2baf2aa390dc17107912f0eb16f09c 
 by 
Christoph Cullmann, on behalf of Miklos Marton.
  Committed on 13/08/2018 at 08:21.
  Pushed by cullmann into branch 'master'.
  
  Add Autodesk EAGLE sch and brd file format to the XML category
  
  M  +1-1data/syntax/xml.xml
  
  
https://commits.kde.org/syntax-highlighting/106694b84c2baf2aa390dc17107912f0eb16f09c
  
  diff --git a/data/syntax/xml.xml b/data/syntax/xml.xml
  index 035bba6..ad34a45 100644
  
  - a/data/syntax/xml.xml
  
  +++ b/data/syntax/xml.xml
  @@ -6,7 +6,7 @@
  


  
  ]>
  -
  +

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14275

To: martonmiklos, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, 
bruns, demsking, vkrause, sars

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

[Miklos Marton]

martonmiklos updated this revision to Diff 38273.
martonmiklos added a comment.


  Updated revision to 8 from 7 as suggested in the review.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14275?vs=38204=38273

REVISION DETAIL
  https://phabricator.kde.org/D14275

AFFECTED FILES
  data/syntax/xml.xml

To: martonmiklos, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me, but we also have to increase the 'version' number from 7 to 
8.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14275

To: martonmiklos, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D14275: Add Autodesk EAGLE sch and brd file format to the XML category

[Miklos Marton]

martonmiklos created this revision.
martonmiklos added a reviewer: Framework: Syntax Highlighting.
martonmiklos added a project: Framework: Syntax Highlighting.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
martonmiklos requested review of this revision.

REVISION SUMMARY
  The Autodesk EAGLE uses plain XML format since a few years, and I think it 
would be useful to load the proper syntax highlighting in Kate automatically.

TEST PLAN
  Create an XML file.
  Rename it to foo.sch
  Open it in kate
  The syntax highlighting should be OK.
  Rename the foo.sch to foo.brd
  Open it in kate
  The syntax highlighting should be OK.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14275

AFFECTED FILES
  data/syntax/xml.xml

To: martonmiklos, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, 
michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, 
sars, dhaumann