D14434: add functions to access keywords

[Dominik Haumann]

dhaumann added a comment.


  @asemke Ok, thanks. It's available for 5.49, which is scheduled for released 
for Saturda 11th of August.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Alexander Semke]

asemke added a comment.


  In D14434#300211 , @dhaumann wrote:
  
  > @asemke Are you sure you reference the correct Task? I cannot find anything 
about keyword lists in your link.
  
  
  @dhaumann yes, I'm sure this is the correct task. That task is about the 
refactoring of the "login-mechanism". The "login" should be only done if needed 
or if possible. At the moment the login to some systems has to _always_ be done 
because the list of keywords is fetched dynamically during the runtime - this 
makes T4760  impossible. The keyworkds are 
needed to properly highlight the content. After the move to KSyntaxHighlighting 
we can use static lists of the keywords provided by this library and there is 
no need to login anymore until there is a real need for this, i.e. the user 
starts calculations.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9e3f07de97ea: add functions to access keywords (authored 
by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14434?vs=38629&id=38799#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14434?vs=38629&id=38799

REVISION DETAIL
  https://phabricator.kde.org/D14434

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Dominik Haumann]

dhaumann added a comment.


  @asemke Are you sure you reference the correct Task? I cannot find anything 
about keyword lists in your link.
  
  Besides that, my change request with respect to API naming still stands.
  
  @jpoelen Before committing, lets have another review round, could you please 
provide an updated patch?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keywordlist

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Alexander Semke]

asemke accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keywordlist

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Alexander Semke]

asemke added a comment.


  In D14434#299932 , @dhaumann wrote:
  
  > In general looks good to me, so +1. I would like to have another +1 from 
@cullmann, @vkrause or @asemke
  
  
  +1
  
  > What I wonder is whether you really need the keyword lists from the 
Definition, or whether you want the currently active keyword lists from the 
current State / Context. I can see that both is useful.
  
  As just replied to the mailing list, both would be useful. But let's do this 
maybe step by step. With this change T4760  
will become possible. After this I'll have a look at how to simplify the 
completion logic in Cantor.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Volker Krause]

vkrause added a comment.


  No objection from me, assuming you have a use-case for this 
(auto-completion?).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[Dominik Haumann]

dhaumann added subscribers: asemke, cullmann, vkrause.
dhaumann added a comment.


  In general looks good to me, so +1. I would like to have another +1 from 
@cullmann, @vkrause or @asemke
  
  What I wonder is whether you really need the keyword lists from the 
Definition, or whether you want the currently active keyword lists from the 
current State / Context. I can see that both is useful.

INLINE COMMENTS

> definition.h:175-176
>  
> +/** Returns the section names of keywords. */
> +QStringList keywordListsNames() const;
> +/** Returns a list of keywords for the specified section. */

Could we change this to:

  /**
   * Returns the names of the keyword lists of this Definition.
   * @since 5.49
   * @see keywordList()
   */
  QStringList keywordLists() const;

> definition.h:177-178
> +QStringList keywordListsNames() const;
> +/** Returns a list of keywords for the specified section. */
> +QStringList keywordList(const QString& name) const;
> +

Same here:

  /**
* Returns the list of keywords for the keyword list @p name.
* @since 5.49
* @see keywordLists()
*/
   QStringList keywordList(const QString& name) const;

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D14434: add functions to access keywords

[jonathan poelen]

jpoelen added a comment.


  This follows 
https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14434: add functions to access keywords

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: kwrite-devel.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  keywordlist

REVISION DETAIL
  https://phabricator.kde.org/D14434

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist.cpp
  src/lib/keywordlist_p.h

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann