D14449: Display used space in GiB also

2018-07-29 Thread Dominik Haumann
dhaumann added a comment.


  We have other places where such information is displayed, e.g. the disk quota 
applet: 
https://kate-editor.org/2015/08/02/plasma-5-keeping-an-eye-on-the-disk-quota/
  Maybe this is useful for input :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-29 Thread Henrik Fehlauer
rkflx added a comment.


  In D14449#300327 , @ngraham wrote:
  
  > Here's another idea for how to express everything while remaining compact 
in the horizontal dimension:
  >
  >   Device capacity: -- 24% full
  >22.5 GiB used, 71.9 GiB free
  >94.4 Gib total size
  
  
  Not bad at all, but due to using 3 lines now puts quite some emphasis on the 
device, while the dialog is about the folder actually. Would this be a 
compromise?:
  
Device capacity: ==- 24% used of 94.4 Gib
 22.5 GiB used, 71.9 GiB free
  
  (Not too happy about the duplication of "used", though.)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-29 Thread Nathaniel Graham
ngraham added a comment.


  +1 for using the same label but putting the information on more than one line 
like @rkflx suggests.
  
  I think there are basically three important pieces of information here:
  
  - Percentage free (for people who don't understand what a "GiB" is--the 
"Simple by default" folks)
  - Amount of free space left (for people who know what a GiB is and want hard 
numbers)
  - Total disk capacity (for the above group of people)
  
  The amount of space used is non-critical, which is probably why it wasn't 
displayed before, but I don't see the harm in adding it if we can avoid using 
too much horizontal space. Here's another idea for how to express everything 
while remaining compact in the horizontal dimension:
  
Device capacity: -- 24% full
 22.5 GiB used, 71.9 GiB free
 94.4 Gib total size

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-29 Thread Shubham
shubham added a comment.


  In D14449#300147 , @rkflx wrote:
  
  > In D14449#300086 , @ngraham 
wrote:
  >
  > >   Device capacity: 94.4 Gib
  > >   Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB used)
  > >
  >
  >
  > That's much better. Another proposal built on top of that:
  >
  >   Device capacity: 94.4 Gib (22.5 GiB used, 71.9 GiB free)
  >-- 24% full 
  >   
  >
  > (Does not duplicate "device", shorter for improved translatability, same 
units on the same line, order of used/free matches what the bar shows.)
  >
  > Or perhaps there is a way to emphasize the most important information a bit 
more (IMO that's "71.9 GiB free")?
  
  
  yeah,agree with that , looks neat also, will do that

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-29 Thread Henrik Fehlauer
rkflx added a comment.


  In D14449#300086 , @ngraham wrote:
  
  >   Device capacity: 94.4 Gib
  >   Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB used)
  >
  
  
  That's much better. Another proposal built on top of that:
  
Device capacity: 94.4 Gib (22.5 GiB used, 71.9 GiB free)
 -- 24% full 
  
  (Does not duplicate "device", shorter for improved translatability, same 
units on the same line, order of used/free matches what the bar shows.)
  
  Or perhaps there is a way to emphasize the most important information a bit 
more (IMO that's "71.9 GiB free")?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-29 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a reviewer: Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for tackling this bug! I approve of the idea here, but the 
presentation you've chosen doesn't seem ideal. How about this instead?
  
Device capacity: 94.4 Gib
Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB used)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-28 Thread Shubham
shubham added a comment.


  F6159605: Screenshot_20180729_112335.png 
: SS

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-28 Thread Dominik Haumann
dhaumann added a comment.


  Can you add a screenshot?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, elvisangelaccio, ngraham
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14449: Display used space in GiB also

2018-07-28 Thread Shubham
shubham created this revision.
shubham added reviewers: elvisangelaccio, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  BUG: 334263

TEST PLAN
  1. Goto properties
  2. Used space displayed in GiB also

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, elvisangelaccio, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns