D14449: Modify device usage information

pino added a comment. In D14449#335788 , @shubham wrote: > won't the pie chart representation look good, as we have in windows? That would be way too much wasted space for eye candy. REPOSITORY R241 KIO REVISION DETAIL

D14449: Modify device usage information

ngraham added a comment. A pie chart could work. But is there something wrong with the current representation? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel,

D14449: Modify device usage information

shubham added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

shubham added a comment. won't the pie chart representation look good, as we have in windows? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

shubham added a comment. You plz proceed on it. Right now working on some other patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

ngraham added a comment. Great! Are you gonna do the QFormLayout patch, or should I? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

shubham added a comment. In D14449#315524 , @ngraham wrote: > Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little

D14449: Modify device usage information

ngraham added a comment. Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little quality-of-life improvement. REPOSITORY R241 KIO REVISION DETAIL

D14449: Modify device usage information

shubham abandoned this revision. shubham added a comment. Actually should be implemented using form layout REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham,

D14449: Modify device usage information

ngraham added a task: T9297: Polish file/folder properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

pino added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1189 > +grid->addWidget(l, curRow, 2); > +l->setText(i18nc("Device usage information","%1 used , %2 free", > KIO::convertSize(size - free), KIO::convertSize(free))); > + Also, style for i18n strings: there must

D14449: Modify device usage information

rkflx added a comment. In D14449#303766 , @shubham wrote: > In D14449#300327 , @ngraham wrote: > > > +1 for using the same label but putting the information on more than one line like @rkflx

D14449: Modify device usage information

shubham added a comment. In D14449#300327 , @ngraham wrote: > +1 for using the same label but putting the information on more than one line like @rkflx suggests. sorry for causing trouble : ( REPOSITORY R241 KIO REVISION DETAIL

D14449: Modify device usage information

rkflx added a comment. > This comment has been deleted. You are doing this in every other Diff, which is a bit annoying. Please first check what you wrote, then click on Send. Otherwise people will just ignore notifications. > is there any other simpler way to achieve this?

D14449: Modify device usage information

shubham added a comment. In D14449#303710 , @rkflx wrote: > - The vertical spacing between the first and the second line is too big, it should be the same as for Size:. is there any other simpler way to achieve this? INLINE COMMENTS >

D14449: Modify device usage information

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. Thanks, looking better than before now. There are still some improvements you could make: - There is a superfluous space before the comma in the second line. - I'd prefer the

D14449: Modify device usage information

shubham edited reviewers, added: rkflx; removed: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx, elvisangelaccio Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

shubham updated this revision to Diff 39120. shubham added a comment. F6176187: 2.png @rkflx is this okay now? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14449?vs=38784=39120 REVISION DETAIL

D14449: Modify device usage information

shubham added a comment. > Not if you set a maximum width. @rkflx eeh, skipped from my mind btw , then it is doable REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann,

D14449: Modify device usage information

rkflx added a comment. In D14449#303660 , @shubham wrote: > > Let me plug my suggestion again: > > > > Device capacity: ==- 24% used of 94.4 Gib > >22.5 GiB used, 71.9 GiB free > > > > if this design is

D14449: Modify device usage information

shubham added a comment. > Let me plug my suggestion again: > > Device capacity: ==- 24% used of 94.4 Gib >22.5 GiB used, 71.9 GiB free > if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good.

D14449: Modify device usage information

ngraham added a comment. In D14449#300868 , @rkflx wrote: > Let me plug my suggestion again: > > Device capacity: ==- 24% used of 94.4 Gib >22.5 GiB used, 71.9 GiB free > > > @ngraham Any opinions on that?

D14449: Modify device usage information

dhaumann added a comment. @rkflx Would be fine with this, as long as the alignment is correct (i.e. the text "Device capacity: ==- 24% used of 94.4 Gib" should all be one one line, and the text " 22.5 GiB used, 71.9 GiB free" should be below. The screenshot above is an

D14449: Modify device usage information

rkflx added a comment. In D14449#300841 , @dhaumann wrote: > Device capacity: 94.4 Gib > Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB used) > > > Could you give this a try with screenshot? I'm afraid the

D14449: Modify device usage information

shubham added a comment. no problem REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

dhaumann added a comment. Correct, but "visual cleanness" goes over redundancy (imo). In fact, the information 100 GiB, 20 GiB used (20%), 80 GiB free is also highly redundant. So redundancy is not the argument here. Instead, I think we should follow the best visual design. And the

D14449: Modify device usage information

ngraham added a comment. In D14449#300842 , @shubham wrote: > dhaumann: but that deviec capacity label seems to be redundant, because capacity is simply used + free Yeah, but you have to do mental math to calculate that. It doesn't make

D14449: Modify device usage information

shubham added a comment. In D14449#300841 , @dhaumann wrote: > I think it looks visually distracting that one progress bar line ends up in two lines of text - this should be avoided. > > To behonest, the suggestion by @ngraham makes most

D14449: Modify device usage information

dhaumann added a comment. I think it looks visually distracting that one progress bar line ends up in two lines of text - this should be avoided. To behonest, the suggestion by @ngraham makes most sense to me: Two lines with the distinction of "Device capacity" and "Device usage".

D14449: Modify device usage information

shubham updated this revision to Diff 38784. shubham added a comment. Remove unintentional " "(that was silly) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14449?vs=38740=38784 REVISION DETAIL https://phabricator.kde.org/D14449 AFFECTED FILES

D14449: Modify device usage information

ngraham added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1270 > const int percentUsed = qRound(100.0 * qreal(used) / qreal(size)); > - > + > d->m_capacityBar->setText( Unnecessary/unintentional whitespace change. REPOSITORY R241 KIO REVISION DETAIL

D14449: Modify device usage information

shubham updated this revision to Diff 38740. shubham retitled this revision from "Display used space in GiB also" to "Modify device usage information". shubham added a comment. F6162515: Screenshot_20180730_113005.png Looks neat and tidy REPOSITORY