D14473: Fix KCatalog::translate when translation is same as original text

2018-07-30 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R249:34a22e5ee5d4: Fix KCatalog::translate when translation is same as original text (authored by aacid). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D14473: Fix KCatalog::translate when translation is same as original text

2018-07-30 Thread Chusslove Illich
ilic accepted this revision. ilic added a comment. This revision is now accepted and ready to land. I distinctly remember having had the same quandry once, and then someone from the gettext side said to compare pointers. Even the comment to dngettext call in the plural version of

D14473: Fix KCatalog::translate when translation is same as original text

2018-07-29 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We need to be compare the pointer passed to gettext with the one we get back. If it