D14501: Top-align labels in properties dialog

2018-08-06 Thread Nathaniel Graham
ngraham added a task: T9297: Polish file/folder properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14501 To: rkflx, dhaumann, ngraham, cfeck Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

2018-07-31 Thread Henrik Fehlauer
rkflx added a comment. Just realized this actually fixes a problem present in KDE 3 already (KDE 2 did not have the second line yet, as far as I could tell in a short but very interesting test). In D14501#301044 , @cfeck wrote: > Bonus

D14501: Top-align labels in properties dialog

2018-07-31 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R241:9829d0ef9e74: Top-align labels in properties dialog (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14501?vs=38811=38865 REVISION DETAIL

D14501: Top-align labels in properties dialog

2018-07-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Ah, so much better. REPOSITORY R241 KIO BRANCH kpropertiesdialog-alignment-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D14501 To: rkflx, dhaumann, ngraham, cfeck Cc: cfeck, kde-frameworks-devel,

D14501: Top-align labels in properties dialog

2018-07-30 Thread Christoph Feck
cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Merci :) Bonus points if you submit another patch that addresses the issue where it starts out with only one text line, then (after computing the size), jumps to a two-line layout.

D14501: Top-align labels in properties dialog

2018-07-30 Thread Henrik Fehlauer
rkflx created this revision. rkflx added reviewers: dhaumann, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. rkflx requested review of this revision. REVISION SUMMARY The General tab of KIO's properties dialog shows