D14501: Top-align labels in properties dialog

[Nathaniel Graham]

ngraham added a task: T9297: Polish file/folder properties dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14501

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Henrik Fehlauer]

rkflx added a comment.


  Just realized this actually fixes a problem present in KDE 3 already (KDE 2 
did not have the second line yet, as far as I could tell in a short but very 
interesting test).
  
  In D14501#301044 , @cfeck wrote:
  
  > Bonus points if you submit another patch that addresses the issue where it 
starts out with only one text line, then (after computing the size), jumps to a 
two-line layout.
  >
  > On remote folders, it looks even worse, because the text line is empty, and 
so the "Calculate" button looks disconnected from the Size label.
  
  
  True, but that requires a bit more work than a simple drive-by patch ;) For 
now, I created T9297: Polish file/folder properties dialog 
 for coordination.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-alignment-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14501

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9829d0ef9e74: Top-align labels in properties dialog 
(authored by rkflx).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14501?vs=38811=38865

REVISION DETAIL
  https://phabricator.kde.org/D14501

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Ah, so much better.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-alignment-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14501

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Merci :)
  
  Bonus points if you submit another patch that addresses the issue where it 
starts out with only one text line, then (after computing the size), jumps to a 
two-line layout.
  
  On remote folders, it looks even worse, because the text line is empty, and 
so the "Calculate" button looks disconnected from the Size label.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-alignment-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14501

To: rkflx, dhaumann, ngraham, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

[Henrik Fehlauer]

rkflx created this revision.
rkflx added reviewers: dhaumann, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
rkflx requested review of this revision.

REVISION SUMMARY
  The General tab of KIO's properties dialog shows labels on the
  left side, and properties on the right, creating a table-like structure.
  Commonly a label should be aligned vertically in such a way it matches
  the first line of the properties, to make it clear which properties it
  belongs to.
  
  However, this was not yet the case for the Size label.

TEST PLAN
  In Dolphin, select a folder and press [Alt] + [Return]. All labels in
  Properties > General should be top-aligned.
  Before: F6165126: kio-properties-before.png 

  After: F6165125: kio-properties-after.png 


REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-alignment-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14501

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: rkflx, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns