apol abandoned this revision.
apol added a comment.
Probably not worth it if it needs to become public.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D14504
To: apol, #frameworks, ilic
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
Has this been measured to actually reduce the number of string allocations?
(e.g. using heaptrack)?
If so, I'm fine with it. If a public API is needed, then indeed that will
have different considerations -- it might want to them wrap the internal
pino added a comment.
TBH I had the idea of making `splitLocale()` public, since it was a public
API in `KLocale`. I still see a couple of users of it, and in the past I
remember people working around the lack of `splitLocale()` by doing the same
job on their own, when porting away from
apol created this revision.
apol added reviewers: Frameworks, ilic.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
We are not using them on their own, so it's doable.
