D14565: Fix overflow in rounding code

This revision was automatically updated to reflect the committed changes. Closed by commit R244:ea2779611800: Fix overflow in rounding code (authored by svuorela). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=39024&id=39025 REVISION DETAIL ht

D14565: Fix overflow in rounding code

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Merci! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14565 To: svuorela, cfeck, safaalfulaij Cc: kde-frameworks-devel, michaelh, ngraham, brun

D14565: Fix overflow in rounding code

svuorela added a comment. In D14565#302581 , @cfeck wrote: > In D14565#302551 , @safaalfulaij wrote: > > > Maybe you should use `largeValue` instead of `largevalue`. > > > Yes, that would be co

D14565: Fix overflow in rounding code

svuorela updated this revision to Diff 39024. svuorela added a comment. s/largevalue/largeValue/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14565?vs=38978&id=39024 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14565 AFFECTED FILE

D14565: Fix overflow in rounding code

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. In D14565#302551 , @safaalfulaij wrote: > Maybe you should use `largeValue` instead of `largevalue`. Yes, that would be consis

D14565: Fix overflow in rounding code

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Worked great, thanks! Maybe you should use `largeValue` instead of `largevalue`. But please take an approval from a developer, it worked for me but I have no idea if it can c

D14565: Fix overflow in rounding code

svuorela created this revision. svuorela added reviewers: cfeck, safaalfulaij. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY qRound works with int. BUG: 397008