D14569: Make it possible for ECM to detect po files at configure time

2018-08-06 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:02881711cfce: Make it possible for ECM to detect po files 
at configure time (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14569?vs=39197=39198

REVISION DETAIL
  https://phabricator.kde.org/D14569

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  modules/ECMPoQmTools.cmake

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

2018-08-06 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 39197.
apol added a comment.


  Correct version

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14569?vs=38983=39197

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  modules/ECMPoQmTools.cmake

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

2018-08-04 Thread Christophe Giboudeaux 
cgiboudeaux added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:98
> +#
> +# Since 5.49.0
> +#

Too late for 5.49

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

2018-08-03 Thread Christophe Giboudeaux 
cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> KDECMakeSettings.cmake:95
> +#
> +# ``KDE_L10N_SYNC_TRANSLATIONS`` (OFF by default) will downloadthe 
> translations at configuration
> +# time instead of build time.

typo, "download the"

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14569: Make it possible for ECM to detect po files at configure time

2018-08-02 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  ECMPoQmTools will need to have the translations downloaded at configure time 
instead of on build time, otherwise it needs an awkward second configure.
  To that end we introduce a KDE_L10N_SYNC_TRANSLATIONS variable that allows it 
to do so.
  ECMPoTools will download the translations in the build directory, because 
cmake shouldn't touch the sources. Have it check the build directory too when 
the macro is called.

TEST PLAN
  Built analitza translations.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  modules/ECMPoQmTools.cmake

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns