D14609: Do not return reference

2018-08-04 Thread Shubham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:65f56f12aa7f: Do not return reference (authored by 
shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14609?vs=39097=39099

REVISION DETAIL
  https://phabricator.kde.org/D14609

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp
  src/filewidgets/kfileplaceeditdialog_p.h

To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham 
shubham added a comment.


  using arc land --rev id, arc gives error saying Audit Failure : Non full name

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Christoph Feck 
cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham 
shubham added a reviewer: broulik.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham 
shubham updated this revision to Diff 39097.
shubham added a comment.


  Remove **cons**t

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14609?vs=39078=39097

REVISION DETAIL
  https://phabricator.kde.org/D14609

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp
  src/filewidgets/kfileplaceeditdialog_p.h

To: shubham, ngraham, cfeck
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Kai Uwe Broulik 
broulik added a comment.


  Also remove the `const`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

To: shubham, ngraham, cfeck
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham 
shubham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

To: shubham, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham 
shubham created this revision.
shubham added reviewers: ngraham, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Can not return a reference in private API

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14609

AFFECTED FILES
  src/filewidgets/kfileplaceeditdialog.cpp
  src/filewidgets/kfileplaceeditdialog_p.h

To: shubham, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns