D14663: Give the "invalid directory name" dialog a cancel button

2018-08-08 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:63178e2fe045: Give the invalid directory name 
dialog a cancel button (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14663?vs=39275=39311

REVISION DETAIL
  https://phabricator.kde.org/D14663

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, elvisangelaccio, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-08 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D14663

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks, elvisangelaccio, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-07 Thread Nathaniel Graham 
ngraham updated this revision to Diff 39275.
ngraham added a comment.


  Rebase on latest master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14663?vs=39234=39275

BRANCH
  arcpatch-D14663

REVISION DETAIL
  https://phabricator.kde.org/D14663

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, elvisangelaccio, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-07 Thread Nathaniel Graham 
ngraham added reviewers: elvisangelaccio, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks, elvisangelaccio, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-06 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-06 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14663

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14663: Give the "invalid directory name" dialog a cancel button

2018-08-06 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Adds a cancel button to the "Invalid Directory Name" dialog.

TEST PLAN
  - Try to create a new folder named "." or "..
  - In the resulting dialog, click Enter a DIfferent Name -> you are prompted 
to choose a new name
  - Enter "." or ".." again
  - In the resulting dialog, click Cancel -> dialog disappears
  - Do the above, but enter a valid name when prompted -> the folder is created 
using the valid name

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14663

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns