D14724: autotests: don't fail if an unrelated window shows up.
dfaure closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson, jtamate Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. As I don't have enough contiguous free time even to test it again, feel free to commit. You can add a comment to remember that it doesn't fix all the cases but is an improvement over previous situation. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson, jtamate Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
dfaure added a comment. That doesn't tell me much about the failure you mention -- what, how and why... I still think the patch is an improvement and should be pushed -- but now I regret putting it up for review, I almost completely forgot about it REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
jtamate added a comment. It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 . or ctest -j4 . 13/15 Test #3: plasma-dialogstatetest ...***Failed2.42 sec 3/15 Test #3: plasma-dialogstatetest ...***Failed1.71 sec REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
dfaure added a comment. @hein - or anyone else - ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
dfaure added reviewers: broulik, davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
D14724: autotests: don't fail if an unrelated window shows up.
dfaure created this revision. dfaure added reviewers: hein, drosca. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Running anything else in parallel to this test would make it fail, because windowAdded() would be emitted with an unrelated window. If we couldn't find our dialog when the signal is emitted, just keep waiting for the signal to be emitted again. TEST PLAN ctest -j 8 . REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14724 AFFECTED FILES autotests/dialogstatetest.cpp To: dfaure, hein, drosca Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns
