cullmann added a comment.
> Does KTE only support one comment marker of each type? Then this is ok IMHO.
Yes, all others were silently discarded.
Later one should check that there is only on in the static checker.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
vkrause added a comment.
Does KTE only support one comment marker of each type? Then this is ok IMHO.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14763
To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,
dhaumann created this revision.
dhaumann added reviewers: cullmann, vkrause.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Added functios
dhaumann added a comment.
@vkrause We simply decided to commit this now. But a review from your side is
still appreciated ;)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14763
To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7a8843f171e8: Definition: Expose command markers
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14763?vs=39512=39545
REVISION
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
> I think that is ok
REPOSITORY
R216 Syntax Highlighting
BRANCH
expose-comment-markers (branched from master)
REVISION DETAIL
cullmann added a comment.
Ok with that Volker?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14763
To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cullmann, sars, dhaumann
cullmann added a comment.
I think later we should check for not more than one marker per type in the
files, but otherwise that is ok for me now.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D14763
To: dhaumann, cullmann, vkrause
Cc: kwrite-devel,
