dfaure closed this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D14927
To: dfaure, adridg, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14927
To: dfaure, adridg, arichardson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
ping?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D14927
To: dfaure, adridg, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure updated this revision to Diff 48823.
dfaure added a comment.
Improved fix so that testDefaults passes too
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14927?vs=39993=48823
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14927
adridg added a comment.
Sorry, this is getting very confusing:
- when running all tests, unpatched: testDelete and testThreads fail
- when running all tests, patched: testDefaults fails
I suspect there are some more missing canonicalizations, but I don't have
time right now to go
adridg added a comment.
Without patch, all tests
Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms
The two failed tests are:
- testThreads
- testDelete
With patch, all tests
=
Totals: 45 passed, 1 failed, 0
adridg added a comment.
This shows up in the unit tests. Whether it has any effect in real life is
unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout --
has /home -> /usr/home or /home -> usr/home, and of course there could be weird
user setups as well where .cache
dfaure created this revision.
dfaure added reviewers: adridg, arichardson.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
When /home is a symlink, for instance (as is
