D15000: Display mounted file system type in properties dialog

shubham added a comment. Move Mounted from into conditional. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40397. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40312=40397 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik, ngraham Cc:

D15000: Display mounted file system type in properties dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Let's move the new "Mounted from:" code to within the conditional that determines whether or not to show "Mounted on:". We should show both or neither, not just one.

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40312. shubham added a comment. Add mounted from label REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40236=40312 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

ngraham added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40236. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40233=40236 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: broulik,

D15000: Display mounted file system type in properties dialog

shubham added a comment. 1. use KMountPoint::mountPoint() 2. Move everything into isLocal REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40233. shubham edited the summary of this revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40219=40233 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1161 > > +l = new QLabel(i18n("File system:"), d->m_frame); > +grid->addWidget(l, curRow, 0, Qt::AlignRight); Captailize: File System > kpropertiesdialog.cpp:1164 > + > +QStorageInfo *fileSystem =

D15000: Display mounted file system type in properties dialog

shubham removed a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40219. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40217=40219 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc:

D15000: Display mounted file system type in properties dialog

shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

shubham created this revision. shubham added a reviewer: dfaure. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY F6209381: Screenshot_20180822_173758.png