D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns added a comment. Thanks to arc for throwing my commit message away ... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns added a dependency: D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh,

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns updated this revision to Diff 42629. bruns added a comment. Use same pattern as KDE_INSTALL_USE_QT_SYS_PATHS REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=42605&id=42629 BRANCH python3_support REVISION DETAIL https://phabri

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns updated this revision to Diff 42605. bruns added a comment. rebase REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=40398&id=42605 BRANCH python3_support REVISION DETAIL https://phabricator.kde.org/D15070 AFFECTED FILES fin

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

2018-09-16 Thread Stefan Brüns
bruns planned changes to this revision. bruns added a comment. Postponed this to do some cleanup first: D15558 , D15559 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: br

D15070: Bindings: Query the install directory from python

2018-09-07 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D15070#318496 , @bruns wrote: > And why isn't it up to the user to set GPB_PYTHON2_SITEARCH when installing out of the usual directories? Because we don't install things out of CMAKE_PREFIX_PATH unless aske

D15070: Bindings: Query the install directory from python

2018-08-31 Thread Stefan Brüns
bruns added a comment. In D15070#318493 , @bcooksley wrote: > We could, however that would not help people installing it as a regular user, rather than as root. > If I run this right now, as an unprivileged user, I get the following path ret

D15070: Bindings: Query the install directory from python

2018-08-31 Thread Ben Cooksley
bcooksley added a comment. We could, however that would not help people installing it as a regular user, rather than as root. If I run this right now, as an unprivileged user, I get the following path returned: >>> sysconfig.get_python_lib( plat_specific=True,standard_lib=False )

D15070: Bindings: Query the install directory from python

2018-08-31 Thread Stefan Brüns
bruns added a comment. If you can change PYTHONPATH for execution, why can't you specify GPB_PYTHONx_SITEARCH? I would expect if I do not specify a path manually, it should be installed in the default location. This btw. **does** honor PREFIX/EXEC_PREFIX, see https://docs.python.org/3/d

D15070: Bindings: Query the install directory from python

2018-08-31 Thread Ben Cooksley
bcooksley added a comment. All we do is set PYTHONPATH, to ensure that the directory we install additional things to is searched by Python. It is imperative however that things are not installed outside of CMAKE_INSTALL_PREFIX otherwise they will be missed by the capture process, and wi

D15070: Bindings: Query the install directory from python

2018-08-31 Thread Stefan Brüns
bruns added a comment. @bcooksley Of course I can not guarantee it does not break CI, but as long as it follows generic python standards and rules (i.e. properly setup distutils) it should work. On the other hand, I can guarantee it currently is broken for a number of distributions. RE

D15070: Bindings: Query the install directory from python

2018-08-24 Thread Stefan Brüns
bruns added a comment. In D15070#315030 , @bcooksley wrote: > Please ensure that wherever it is installed to ends up within CMAKE_INSTALL_PREFIX otherwise this will end up failing on the CI system. > > The CI system takes care of setting PYT

D15070: Bindings: Query the install directory from python

2018-08-24 Thread Ben Cooksley
bcooksley added a comment. Please ensure that wherever it is installed to ends up within CMAKE_INSTALL_PREFIX otherwise this will end up failing on the CI system. The CI system takes care of setting PYTHONPATH accordingly to ensure resources are found. REPOSITORY R240 Extra CMake Modu

D15070: Bindings: Query the install directory from python

2018-08-24 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The correct install directory is distro and arch specific,