fvogt added a comment.
With a few modification the patch is correct and necessary though.
statfs (not statvfs!) has in the documentation: `Fields that are undefined
for a particular filesystem are set to 0.`. Currently KIO just returns garbage
in that case.
The KMountPoint calls
broulik abandoned this revision.
broulik added a comment.
It seems by adding gvfsd support for `KMountPoint` this has become obsolete.
$ df /run/user/1000/gvfs/
Filesystem 1K-blocks Used Available Use% Mounted on
gvfsd-fuse 0 0 0-
dfaure accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15146
To: broulik, dfaure, ngraham, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik added a comment.
Ping :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15146
To: broulik, dfaure, ngraham, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Quite fantastic. Can reproduce the initial problem, the fact that this fixes
it, and the new permissions issue, which I can also confirm is fixed with
D15154
broulik created this revision.
broulik added reviewers: dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
BUG: 344146
TEST PLAN
Accessed a SMB share from Nautilus, chose "Open in
broulik added a reviewer: fvogt.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15146
To: broulik, dfaure, ngraham, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
