D15213: Provide icons for 2x scaling

2018-09-12 Thread Nathaniel Graham
ngraham added a comment.


  Hah, yes it did!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-12 Thread Christoph Feck
cfeck added a comment.


  Did this fix bug 398094?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: cfeck, acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello closed this revision.
rizzitello added a comment.


  landed: 
https://cgit.kde.org/breeze-icons.git/commit/?id=2dcc2b712a88e726f31f3a4732ba2c39c01a2bce

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-06 Thread Andrew Crouthamel
acrouthamel added a comment.


  I love all of these HIDPI fixes lately.

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-06 Thread Nathaniel Graham
ngraham added a comment.


  Fantastic, shipit!

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-06 Thread Chris Rizzitello
rizzitello added a comment.


  In D15213#321121 , @ngraham wrote:
  
  > Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon 
will need an `@2x` symlink?
  
  
  There will be no need for that since I have simlinked the folders using `ln 
-sdr` so 16@2x is a simlink to 16  no icons links.

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-05 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  So if I apply this patch, use a 2x scale factor, and launch Dolphin (from 
18.08.2 or git master), I should see all line-art icons in my places panel, 
right? It works for 2x, and 1.5x, but at 1.7x and 1.3x I hit 
https://bugs.kde.org/show_bug.cgi?id=396990. But that's not your fault, so... 
approved!
  
  Does this mean that every new 16px, 22px, 24px, and 32px monochrome icon will 
need an `@2x` symlink?

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns


D15213: Provide icons for 2x scaling

2018-09-05 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Alright, Dolphin patches merged to stable. This can go in now, thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  2xIcons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15213: Provide icons for 2x scaling

2018-09-03 Thread Chris Rizzitello
rizzitello retitled this revision from "Link 16px icon folders to 16@2" to 
"Provide icons for 2x scaling".
rizzitello edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15213

To: rizzitello, #vdg, #plasma
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns