D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks, I can. I'm getting an error in Arcanist, so let me diagnose that and 
I'll land it.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Can you commit yourself?

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15337#322043 , @dhaumann wrote:
  
  > Solarized dark still only has 28 colors, right? Can you add the missing 
ones?
  
  
  Man, I'm looking forward to this JSON system in the future. LOL. Ok, fixed 
again. I counted all of them before commit.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41181.
acrouthamel added a comment.


  - Added three missing definitions

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41177=41181

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added a comment.


  Solarized dark still only has 28 colors, right? Can you add the missing ones?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel added a comment.


  @dhaumann, I've added these colors to KSyntaxHighlighting over here: D15340 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked 2 inline comments as done.
acrouthamel added a comment.


  You were right again. For some reason that Others= disappeared from my 
~/.config/katesyntaxhighlightingrc so I didn't notice it. Even though it was 
defined and displaying fine in the GUI. Weird.
  
  I also made a few more adjustments to Markers colors to adhere to the 
Solarized rules for gray colors. I think it is pretty set now, unless something 
else disappeared...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41177.
acrouthamel added a comment.


  - Fixed Others definition

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41176=41177

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41176.
acrouthamel added a comment.


  - Some Marker color tweaks to ensure Solarized interaction rule adherence

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41172=41176

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> katesyntaxhighlightingrc:143
> -Operator=ff93a1a1,ff93a1a1,-,-,,---
> -Others=ff859900,ff859900,-,-,,---
> -Preprocessor=ff27ae60,ff27ae60,-,-,,---

Isn't "Others" now missing? Every color theme should define 31 colors. If this 
was not the case before, then it was also wrong before :)

Can you check again?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41172.
acrouthamel added a comment.


  - Fixed Light scheme Error color

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41171=41172

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41171.
acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  - Solarized Light Region Marker fix and small Dark tweak.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41170=41171

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel marked an inline comment as done.
acrouthamel added a comment.


  I've fixed the section. I'm actually working on the KSyntaxHighlighting 
themes now, you'll see those in another patch.

INLINE COMMENTS

> dhaumann wrote in katesyntaxhighlightingrc:104
> Am I mistaken, or did you remove the section here?

No, you're right, that's a mistake. I just fixed it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel updated this revision to Diff 41170.
acrouthamel added a comment.


  - Fixed section code

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15337?vs=41168=41170

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Dominik Haumann]

dhaumann added a comment.


  Thanks for working on this. Looks good to me - just a minor question about 
the section for Solarized light.
  
  And also related: would you also create the .theme files for 
KSyntaxHighlighting?

INLINE COMMENTS

> katesyntaxhighlightingrc:104
>  # Solarized (light), Default Item Styles
> -[Default Item Styles - Schema Solarized (light)]
> -Alert=ffd33682,ffd33682,1-,-,,---

Am I mistaken, or did you remove the section here?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel edited the summary of this revision.
acrouthamel edited the test plan for this revision.
acrouthamel added reviewers: Kate, KTextEditor, Framework: Syntax Highlighting.
acrouthamel added a project: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D15337

To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D15337: Fix Solarized Light and Dark color schemes

[Andrew Crouthamel]

acrouthamel created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
acrouthamel requested review of this revision.

REVISION SUMMARY
  Solarized Light contrast was low. Upon investigation it was determined
  much of the color scheme did not follow Solarized base 16 colors or
  rules. Color scheme for both Dark and Light variants were adjusted to
  match the latest Solarized color scheme release palette and color
  interaction rules. Color schemes were also matched closely to the
  Vim color scheme created by the original Solarized author.

TEST PLAN
  Open Kate with new rc files and inspect the Color settings.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-solarized-colors

REVISION DETAIL
  https://phabricator.kde.org/D15337

AFFECTED FILES
  src/data/kateschemarc
  src/data/katesyntaxhighlightingrc

To: acrouthamel
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann