D15443: [server] Allow multiple touch interfaces per client

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7bb2a225521c: [server] Allow multiple touch interfaces per client (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15443?vs=41916=46752

D15443: [server] Allow multiple touch interfaces per client

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH refactorSeatTouch REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh,

D15443: [server] Allow multiple touch interfaces per client

romangg updated this revision to Diff 41916. romangg added a comment. Do not forget id equals 0 check and add assert. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15443?vs=41513=41916 BRANCH refactorSeatTouch REVISION DETAIL

D15443: [server] Allow multiple touch interfaces per client

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in seat_interface.cpp:1332 > what happened to the > if (id == 0 ) > > which is making sure if you multi touch we only send the first as a mouse > event. Good catch. Thanks. > davidedmundson wrote in

D15443: [server] Allow multiple touch interfaces per client

davidedmundson added inline comments. INLINE COMMENTS > seat_interface.cpp:1332 > -d->touchInterface.focus.touch->down(id, serial, globalPosition - > d->touchInterface.focus.offset); > -} else if (id == 0 && focusedTouchSurface()) { > #if HAVE_LINUX_INPUT_H what happened to the

D15443: [server] Allow multiple touch interfaces per client

romangg retitled this revision from "[server] Allow multiple touch interfaces per client and remove fallback code" to "[server] Allow multiple touch interfaces per client". romangg edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL

D15443: [server] Allow multiple touch interfaces per client

romangg edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg updated this revision to Diff 41513. romangg added a comment. Readd fall back code REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15443?vs=41445=41513 BRANCH refactorSeatTouch REVISION DETAIL https://phabricator.kde.org/D15443 AFFECTED

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a comment. In D15443#324889 , @davidedmundson wrote: > I don't understand removing this. If I have an app that doesn't understand touch doesn't it make sense to synthesise a pointer? I didn't read the code correctly.

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

davidedmundson added a comment. Oh, I see what you're saying, I misread, sorry. That does indeed make sense. > Some undocumented fallback code has been removed as well. Platforms not supporting touch are just considered not capable instead. I don't understand removing this. If I

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a comment. I believe it works like this: A seat has one global pointer, one global keyboard and one global touch "object" each. But clients can bind to them multiple times. That's why there are focus.pointers and focus.keyboards vectors although there is only one global

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

davidedmundson added a comment. > has been for no apparent reason From the spec (emphasis mine) The wl_touch interface represents **a** touchscreen associated with a seat. The wl_pointer interface represents **one or more** input devices, The wl_keyboard interface

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg added a dependent revision: D15464: [server] Touch drag support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15443: [server] Allow multiple touch interfaces per client and remove fallback code

romangg created this revision. romangg added reviewers: KWin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The touch related code in the seat interface class has been for no apparent