This revision was automatically updated to reflect the committed changes.
Closed by commit R127:09b5adee94ad: [server] Touch drag support (authored by
romangg).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15464?vs=45164=46753
REVISION DETAIL
romangg updated this revision to Diff 45164.
romangg added a comment.
- No touch motion on drag
- Add touch dnd autotest
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15464?vs=41923=45164
BRANCH
touchDrag
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
touchDrag
REVISION DETAIL
https://phabricator.kde.org/D15464
To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh,
romangg updated this revision to Diff 41923.
romangg marked an inline comment as done.
romangg added a comment.
- Fix id setting and cancel touch drags
- Reapply position of first touch on drag
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
romangg marked 3 inline comments as done.
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in seat_interface.cpp:1331
> If I add 2 IDs
>
> [0,1]
>
> then remove ID 0
>
> [1]
>
> with the old code I would get the ID 2, with this I'll get a second ID 1
Redid this one too
davidedmundson added inline comments.
INLINE COMMENTS
> datadevice_interface.cpp:102
> {
> // TODO: allow touch
> +const bool pointerGrab = seat->hasImplicitPointerGrab(serial) &&
> seat->focusedPointerSurface() == origin;
done
> seat_interface.cpp:1331
> Q_D();
> -const
romangg added a dependent revision: D15466: Add Wayland touch drag and drop
support.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15464
To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
romangg added a dependency: D15443: [server] Allow multiple touch interfaces
per client and remove fallback code.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15464
To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
romangg created this revision.
romangg added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.
REVISION SUMMARY
Adds functionality to do drag and drop with touch screens.
TEST PLAN
