D15479: fix for macOS

apol added a comment. In D15479#358797 , @vonreth wrote: > thx, we where using the patch since ages on binary-factory, https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=b84b9f3fd64594bb5e7959472a58309d54ee06fa Then please don't

D15479: fix for macOS

vonreth added a comment. thx, we where using the patch since ages on binary-factory, https://cgit.kde.org/craft-blueprints-kde.git/commit/?id=b84b9f3fd64594bb5e7959472a58309d54ee06fa REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson

D15479: fix for macOS

This revision was automatically updated to reflect the committed changes. Closed by commit R272:4eb0a90c7dd9: fix for macOS (authored by Hessel van der Molen hmolen.scie...@gmail.com, committed by vonreth). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE

D15479: fix for macOS

yurikoles added a comment. In D15479#327944 , @bcooksley wrote: > Okay. That's quite an unusual error as that should work. > > We'll have to let the CI system confirm this one. Please go ahead and commit. I have no rights.

D15479: fix for macOS

bcooksley added a comment. Okay. That's quite an unusual error as that should work. We'll have to let the CI system confirm this one. Please go ahead and commit. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson Cc: bcooksley,

D15479: fix for macOS

yurikoles added a comment. In D15479#325443 , @bcooksley wrote: > Does this still build on Linux systems? I have problems building it under Linux even without a patch. I had tried Arch AUR (kdnssd-git) and Ubuntu 18.10 (cosmic), which

D15479: fix for macOS

bcooksley added a comment. Does this still build on Linux systems? REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson Cc: bcooksley, arichardson, yurikoles, kde-frameworks-devel, michaelh, ngraham, bruns

D15479: fix for macOS

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. I can confirm that this fixes the build for me. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 To: yurikoles, arichardson Cc: arichardson,

D15479: fix for macOS

yurikoles added a comment. Author is: Hessel van der Molen Copyright confirmed in comment to commit in kde-mac/kde homebrew tap. REPOSITORY R272 KDNSSD REVISION

D15479: fix for macOS

yurikoles created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurikoles requested review of this revision. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D15479 AFFECTED FILES src/mdnsd-publicservice.cpp