D15510: Introduce HKDF

2018-10-16 Thread Alexander Volkov
volkov added a comment. D16248 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: bcooksley, dfaure

D15510: Introduce HKDF

2018-10-16 Thread Ben Cooksley
bcooksley added a comment. This has made the FreeBSD CI builds unhappy unfortunately: https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.11/15/console Due to various issues, QCA isn't built on the Linux CI systems so

D15510: Introduce HKDF

2018-10-15 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15510: Introduce HKDF

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code. REPOSITORY R486 QCA Library BRANCH master REVISION DETAIL https://phabr

D15510: Introduce HKDF

2018-10-08 Thread Alexander Volkov
volkov added a comment. BTW, should I create a review request to reformat code with astyle-kdelibs? REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15510: Introduce HKDF

2018-10-08 Thread Alexander Volkov
volkov updated this revision to Diff 43125. volkov added a comment. more reinterpret_casts REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=43123&id=43125 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES in

D15510: Introduce HKDF

2018-10-08 Thread Alexander Volkov
volkov updated this revision to Diff 43123. volkov added a comment. fixed REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15510?vs=41656&id=43123 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15510 AFFECTED FILES include/QtCrypto/qc

D15510: Introduce HKDF

2018-10-08 Thread Alexander Volkov
volkov added inline comments. INLINE COMMENTS > dfaure wrote in qca-botan.cpp:250 > override? it still supports build with Qt 4 and without C++ 11 REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks, dfaure Cc: dfaure

D15510: Introduce HKDF

2018-10-07 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qca_basic.h:1081 > > +class QCA_EXPORT HKDF : public Algorithm > +{ Missing class documentation. Missing \since tag. > qca-botan.cpp:234 > +public: > +

D15510: Introduce HKDF

2018-09-26 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D15510 To: volkov, iromanov, sitter, #frameworks