This revision was automatically updated to reflect the committed changes.
Closed by commit R280:fa3f31329aea: Add support for Code 128 barcodes (authored
by vkrause).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15511?vs=41659=41685
REVISION DETAIL
svuorela accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R280 Prison
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15511
To: vkrause, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vkrause added inline comments.
INLINE COMMENTS
> svuorela wrote in code128barcodetest.cpp:111
> doesn't QCOMPARE automatically output both ?
Yep, but not perfectly aligned underneath each other, which is extremely
helpful for spotting bit differences.
REPOSITORY
R280 Prison
REVISION DETAIL
vkrause updated this revision to Diff 41659.
vkrause added a comment.
Remove copy/paste mistake.
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15511?vs=41657=41659
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15511
AFFECTED FILES
svuorela added inline comments.
INLINE COMMENTS
> CMakeLists.txt:26
> +)
> +# qt5_add_resources(aztecbarcodetest_srcs aztec/aztec.qrc)
> +
copy/paste error ?
> code128barcodetest.cpp:111
> +qDebug() << "Expected:" << output;
> +}
> +QCOMPARE(v, output);
doesn't
vkrause added a reviewer: svuorela.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D15511
To: vkrause, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REPOSITORY
R280 Prison
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15511
AFFECTED FILES
autotests/CMakeLists.txt
