D15583: [Balooctl] fix directory parent check

ngraham updated this revision to Diff 42152. ngraham edited the test plan for this revision. ngraham added a comment. Remove parent directory check entirely; it's not necessary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15583?vs=42018=42152 BRANCH

D15583: [Balooctl] fix directory parent check

ngraham added a comment. Oh wow, you're right. Let me fix `balooctl` to support that, then. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh,

D15583: [Balooctl] fix directory parent check

bruns added a comment. In D15583#330119 , @ngraham wrote: > In D15583#330085 , @bruns wrote: > > > I think the whole `startsWith` is flawed - it should be possible to have a e.g.

D15583: [Balooctl] fix directory parent check

ngraham added a comment. In D15583#330085 , @bruns wrote: > I think the whole `startsWith` is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded. Hmm, I'm not sure how much

D15583: [Balooctl] fix directory parent check

bruns added a comment. I think the whole `startsWith` is flawed - it should be possible to have a e.g. "/home/user/foo/bar" include when "/home/user/foo" has been excluded. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns,

D15583: [Balooctl] fix directory parent check

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh,

D15583: [Balooctl] fix directory parent check

ngraham updated this revision to Diff 42018. ngraham added a comment. - Address review comments and do it better REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15583?vs=41873=42018 BRANCH fix-hyphen-in-name (branched from master) REVISION DETAIL

D15583: [Balooctl] fix directory parent check

ngraham planned changes to this revision. ngraham added a comment. Actually it looks like we shouldn't even use it anyway for other reasons per the documentation: https://doc.qt.io/qt-5/qdir.html#separator They recommend always using `/` directly like you indicate, so I'll do that.

D15583: [Balooctl] fix directory parent check

anthonyfieroni added a comment. In Qt 5.9 (if i remember correct) was introduced to not have trailing '/' so, QDir::separator should not be used, so better get folder as copy for (QString folder : folders) { if (!folder.endsWith(QLatin1Char('/')) { folder +=

D15583: [Balooctl] fix directory parent check

cfeck resigned from this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] fix directory parent check

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks, cfeck Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15583: [Balooctl] fix directory parent check

ngraham created this revision. ngraham added reviewers: Baloo, Dolphin, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY [Submitting this patch on behalf of James Ausmus, who attached it