D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread Kai Uwe Broulik 
broulik added a comment.


  I also would prefer to do the `fastInsert` change separately as to not 
clutter the diff

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread David Faure 
dfaure added a comment.


  The question of the caching of the KUser usage remains, though.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 42033.
jtamate retitled this revision from "Use String to store UDS_USER and UDS_GROUP 
de tipo String" to "Use String to store UDS_USER and UDS_GROUP of String type, 
use fastInsert.".
jtamate edited the summary of this revision.
jtamate added a comment.


  White at it, use fastInsert.
  And this also fixes the search in the home directory :-).
  The title in English :-).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15635?vs=42029&id=42033

REVISION DETAIL
  https://phabricator.kde.org/D15635

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams