This revision was automatically updated to reflect the committed changes.
Closed by commit R293:95af521127c1: Use String to store UDS_USER and UDS_GROUP
of String type. (authored by jtamate).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15635?vs=42044=42314
dfaure accepted this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15635
To: jtamate, dfaure, #baloo, #frameworks, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,
spoorun, bruns, abrahams
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Code looks better and I can verify that it fixes the bug. Feels a bit faster,
too. Maybe wait for a final review from @broulik or someone in #frameworks
jtamate updated this revision to Diff 42044.
jtamate retitled this revision from "Use String to store UDS_USER and UDS_GROUP
of String type, use fastInsert." to "Use String to store UDS_USER and UDS_GROUP
of String type.".
jtamate edited the summary of this revision.
jtamate edited the test plan
broulik added a comment.
I also would prefer to do the `fastInsert` change separately as to not
clutter the diff
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15635
To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh,
dfaure added a comment.
The question of the caching of the KUser usage remains, though.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15635
To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,
jtamate updated this revision to Diff 42033.
jtamate retitled this revision from "Use String to store UDS_USER and UDS_GROUP
de tipo String" to "Use String to store UDS_USER and UDS_GROUP of String type,
use fastInsert.".
jtamate edited the summary of this revision.
jtamate added a comment.
