D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-25 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:95af521127c1: Use String to store UDS_USER and UDS_GROUP 
of String type. (authored by jtamate).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15635?vs=42044=42314

REVISION DETAIL
  https://phabricator.kde.org/D15635

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/kioslaves/search/kio_search.h

To: jtamate, dfaure, #baloo, #frameworks, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-25 Thread David Faure
dfaure accepted this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Code looks better and I can verify that it fixes the bug. Feels a bit faster, 
too. Maybe wait for a final review from @broulik or someone in #frameworks 
 though before landing.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks, ngraham
Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type.

2018-09-21 Thread Jaime Torres Amate
jtamate updated this revision to Diff 42044.
jtamate retitled this revision from "Use String to store UDS_USER and UDS_GROUP 
of String type, use fastInsert." to "Use String to store UDS_USER and UDS_GROUP 
of String type.".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
jtamate added a comment.


  Copy the methods getUserName and getGroupName from kfile, those are cached, 
should be faster.
  Keep the fastInsert for another revision.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15635?vs=42033=42044

REVISION DETAIL
  https://phabricator.kde.org/D15635

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/kioslaves/search/kio_search.h

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread Kai Uwe Broulik
broulik added a comment.


  I also would prefer to do the `fastInsert` change separately as to not 
clutter the diff

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread David Faure
dfaure added a comment.


  The question of the caching of the KUser usage remains, though.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15635

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D15635: Use String to store UDS_USER and UDS_GROUP of String type, use fastInsert.

2018-09-21 Thread Jaime Torres Amate
jtamate updated this revision to Diff 42033.
jtamate retitled this revision from "Use String to store UDS_USER and UDS_GROUP 
de tipo String" to "Use String to store UDS_USER and UDS_GROUP of String type, 
use fastInsert.".
jtamate edited the summary of this revision.
jtamate added a comment.


  White at it, use fastInsert.
  And this also fixes the search in the home directory :-).
  The title in English :-).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15635?vs=42029=42033

REVISION DETAIL
  https://phabricator.kde.org/D15635

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp

To: jtamate, dfaure, #baloo, #frameworks
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams