ngraham requested changes to this revision.
ngraham added reviewers: Plasma, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.
Thank you for the patch! I see that this is your first KDE contribution, how
exciting! This needs some work, so please don't get discouraged, and I'll help
you where I can. Here are the problems that need to be solved in order for the
patch to be landable:
1. Please see
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch for
information regarding how to format your patch's title and summary sections.
2. The patch doesn't apply and I don't see how it could work; all is does is
remove a comment. The patch you attached to
https://bugs.kde.org/show_bug.cgi?id=395349 is substantially different; can you
edit this revision to have that diff instead? To do that, you can click on the
Edit Revision link in the top-right corner of the page (it may be under the
Action button if your window is narrow.
REVISION DETAIL
https://phabricator.kde.org/D15644
To: lsartorelli, ngraham, #plasma, #frameworks
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
