D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Nathaniel Graham
ngraham added a comment.


  In D15721#331785 , @ndavis wrote:
  
  > Thanks, I really like that series. It gives a real feeling of forward 
momentum for KDE.
  
  
  Yep, that's one of the big reasons why I do it. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Noah Davis
ndavis added a comment.


  In D15721#331723 , @ngraham wrote:
  
  > FYI, this earned a place in next week's Usability & Productivity report 
. :)
  
  
  Thanks, I really like that series. It gives a real feeling of forward 
momentum for KDE.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Nathaniel Graham
ngraham added a comment.


  FYI, this earned a place in next week's Usability & Productivity report 
. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:f729894087c6: Make lock on plasmavault icon visible with 
breeze-dark (authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15721?vs=42213=42312

REVISION DETAIL
  https://phabricator.kde.org/D15721

AFFECTED FILES
  icons-dark/apps/16/plasmavault.svg
  icons-dark/apps/22/plasmavault.svg
  icons/apps/16/plasmavault.svg
  icons/apps/22/plasmavault.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah thanks. For some reason Cuttlefish was not displaying the icon properly. :/
  
  Can confirm the problem and that this fixes it! Will land the patch shortly.

REPOSITORY
  R266 Breeze Icons

BRANCH
  plasmavault-icon-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-25 Thread Noah Davis
ndavis added a comment.


  In D15721#331388 , @ngraham wrote:
  
  > Can you provide steps to reproduce the problem so I can test it? In my 
naive testing, the `plasmavault` icon looks like a lock and shows up fine on 
both Breeze Light and Breeze Dark.
  
  
  Here's one way to reproduce the bug that this change fixes:
  
  1. Switch to the Breeze Dark icon theme
  2. Use the `plasmavault` icon for a favorite place in Dolphin. In this case, 
it's the `~/Vaults` folder.
  
  Here's a close-up of the problem.F6284027: Screenshot_20180925_045058.png 

  
  > I'm also confused by the images you posted (which should be in the Test 
Plan{ section, BTW that depict different icons. Can you help a brotha out?
  
  The pictures are just showing how the icon looks after the change. I suppose 
I should have shown the old version for comparison. I don't actually know what 
the test plan section is for and I don't know where I would find that 
information.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  Can you provide steps to reproduce the problem so I can test it? In my naive 
testing, the `plasmavault` icon looks like a lock and shows up fine on both 
Breeze Light and Breeze Dark. I'm also confused by the images you posted (which 
should be in the Test Plan{ section, BTW that depict different icons. Can you 
help a brotha out?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-24 Thread Andres Betts
abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-23 Thread Noah Davis
ndavis added a comment.


  16px
  F6281723: Screenshot_20180924_005740.png 

  
  22px
  F6281721: Screenshot_20180924_005657.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15721: Make lock on plasmavault icon visible with breeze-dark

2018-09-23 Thread Noah Davis
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Set lock color on Breeze version to #eff0f1 (light2dark script compatibility) 
and the lock on the Breeze Dark version to #31363b.

REPOSITORY
  R266 Breeze Icons

BRANCH
  plasmavault-icon-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15721

AFFECTED FILES
  icons-dark/apps/16/plasmavault.svg
  icons-dark/apps/22/plasmavault.svg
  icons/apps/16/plasmavault.svg
  icons/apps/22/plasmavault.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns