dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> thumbnail.cpp:730
>
> +KFileItem item(fileUrl);
> +
For local files, QFileInfo would be more straightforward, no?
You'd just use
broulik added a comment.
@dfaure Ping
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,
LeGast00n, MrPepe,
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew,
anthonyfieroni added a comment.
What happen to this? Put it to 19.04 for testing.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew,
anthonyfieroni added a comment.
To 18.12 ?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: ngraham, kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew,
michaelh, spoorun,
ngraham added a comment.
+1 from me too.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: ngraham, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef,
anthonyfieroni added a comment.
+1
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15763
To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros,
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, anthonyfieroni, jtamate.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise `PreviewJob` will
