D15778: Log wallet open failure errors

arjun marked an inline comment as done. arjun added a comment. In D15778#333555 , @bruns wrote: > The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit

D15778: Log wallet open failure errors

This revision was automatically updated to reflect the committed changes. Closed by commit R311:c7b064e5a3d5: Log wallet open failure errors (authored by arjun). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15778?vs=42430&id=42538#toc REPOSITORY R311 KWallet CHANGES SINCE LAST UPDAT

D15778: Log wallet open failure errors

bruns added a comment. The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit message. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = > KWallet::Backen

D15778: Log wallet open failure errors

arjun added a comment. I don't see a merge button, Am i supposed to push it via git? REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

arjun removed a reviewer: mlaurent. arjun marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

arjun added a reviewer: mlaurent. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

arjun updated this revision to Diff 42430. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15778?vs=42381&id=42430 REVISION DETAIL https://phabricator.kde.org/D15778 AFFECTED FILES src/runtime/kwalletd/kwalletd.cpp To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, n

D15778: Log wallet open failure errors

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = > KWallet::Backend::openRCToString(rc); > +qWarn

D15778: Log wallet open failure errors

arjun created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arjun requested review of this revision. REVISION SUMMARY Hopefully this would end up on syslog and grab the attention of the sysadmin. REPOSITORY R311 KWallet REVISION DETAIL