D15778: Log wallet open failure errors

[Arjun AK]

arjun marked an inline comment as done.
arjun added a comment.


  In D15778#333555 , @bruns wrote:
  
  > The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which 
ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit 
message.
  
  
  My distro doesn't ship arc, I've manually added the tags.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham

D15778: Log wallet open failure errors

[Arjun AK]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:c7b064e5a3d5: Log wallet open failure errors (authored by 
arjun).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15778?vs=42430&id=42538#toc

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15778?vs=42430&id=42538

REVISION DETAIL
  https://phabricator.kde.org/D15778

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham

D15778: Log wallet open failure errors

[Stefan Brüns]

bruns added a comment.


  The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which 
ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit 
message.

INLINE COMMENTS

> kwalletd.cpp:685
> +const auto errorStr = 
> KWallet::Backend::openRCToString(rc);
> +qCWarning(KWALLETD_LOG) << "Failed to open 
> wallet " << wallet << errorStr;
>  kpd->setPrompt(i18n(

nitpick - `qCWarning(..)` add spaces between arguments by default, so there is 
a double space between "wallet" and 

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: bruns, mlaurent, kde-frameworks-devel, michaelh, ngraham

D15778: Log wallet open failure errors

[Arjun AK]

arjun added a comment.


  I don't see a merge button,  Am i supposed to push it via git?

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun removed a reviewer: mlaurent.
arjun marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun added a reviewer: mlaurent.

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun updated this revision to Diff 42430.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15778?vs=42381&id=42430

REVISION DETAIL
  https://phabricator.kde.org/D15778

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwalletd.cpp:685
> +const auto errorStr = 
> KWallet::Backend::openRCToString(rc);
> +qWarning() << "Failed to open wallet " << 
> wallet << errorStr;
>  kpd->setPrompt(i18n(

Use :
qCWarning(KWALLETD_LOG) ...

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15778

To: arjun, mlaurent
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

[Arjun AK]

arjun created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arjun requested review of this revision.

REVISION SUMMARY
  Hopefully this would end up on syslog and grab the attention of the sysadmin.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15778

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: arjun
Cc: kde-frameworks-devel, michaelh, ngraham, bruns