dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
The warning needs to be removed then. We can't really warn at the time of
using a variable.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
apol added a comment.
Has this been fixed? I haven't seen these warnings
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15795
To: dinoh, apol, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
bruns resigned from this revision.
bruns added a comment.
sorry, busy with other stuff
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15795
To: dinoh, apol, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dinoh added inline comments.
INLINE COMMENTS
> ltoscano wrote in KDEInstallDirs.cmake:564
> I'm going to comment only on this, but the others (most, if not all) are the
> same. If you check the definition of _define_relative, this parameter is:
>
> oldstylename (optional): the old-style name
ltoscano added inline comments.
INLINE COMMENTS
> KDEInstallDirs.cmake:564
> "documentation bundles generated using kdoctools"
> -HTML_INSTALL_DIR)
> +KDE_INSTALL_DOCBUNDLEDIR)
> _define_relative(KCFGDIR DATAROOTDIR "config.kcfg"
I'm going to comment only on this, but the others
dinoh added reviewers: apol, bruns, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15795
To: dinoh, apol, bruns, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dinoh created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
dinoh requested review of this revision.
REVISION SUMMARY
KDEInstallDirs.cmake used the deprecated format for install dirs internally
and thus caused a
