D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R245:419a551baa3e: [Fstab] Show non-empty share name in case 
root fs is exported (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15798?vs=42427&id=42429

REVISION DETAIL
  https://phabricator.kde.org/D15798

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Alright, ship it

REPOSITORY
  R245 Solid

BRANCH
  ensure_nonempty_nfs_exportname

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Stefan Brüns 
bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> broulik wrote in fstabdevice.cpp:45
> This should probably be moved outside this if, you get the same bug when you 
> do ``//server/`

SMB/Cifs share names can never be empty, i.e. you always have 
`//server/`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:45
>  m_product = m_device.mid(m_device.indexOf(":/") + 2);
> +if (m_product.isEmpty()) {
> +m_product = QStringLiteral("/");

This should probably be moved outside this if, you get the same bug when you do 
``//server/`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Stefan Brüns 
bruns edited the summary of this revision.
bruns added a reviewer: broulik.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15798

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15798: [Fstab] Show non-empty share name in case root fs is exported

2018-09-27 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The leading slash is stripped to save some space for the human readable
  description ("share on server"). In case of an exported root filesystem,
  this creates an empty export name, so readd the slash.

TEST PLAN
  Create two entries in fstab:
  `server:/  /mnt/a/ nfs defaults 0 0`
  `server:/b /mnt/b/ nfs defaults 0 0`
  run e.g. solid-hardware5 list details
  result
  ` description = '/ on server'`
  ` description = 'b on server'`

REPOSITORY
  R245 Solid

BRANCH
  ensure_nonempty_nfs_exportname

REVISION DETAIL
  https://phabricator.kde.org/D15798

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns