This revision was automatically updated to reflect the committed changes.
Closed by commit R320:75ee4dfb4042: Add a specific error string for ENOTEMPTY
return code. (authored by madcatx).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15871?vs=42807=43119
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15871
To: madcatx, elvisangelaccio, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
madcatx updated this revision to Diff 42807.
madcatx added a comment.
Changed the KIO error code from ERR_INTERNAL to more specific
ERR_CANNOT_RMDIR.
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15871?vs=42645=42807
REVISION DETAIL
madcatx added a comment.
Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which
translate to the same value with the latter being deprecated. I'll update the
patch to use ERR_CANNOT_RMDIR.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
madcatx added a comment.
Well, this
(https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated15)
marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should
use instead?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15871
dfaure added a comment.
kio_file returns KIO::ERR_CANNOT_RMDIR when trying to delete a non-empty
directory, maybe kio_smb could do the same? Although I see that the above isn't
dependent on the command being executed But well, is there any other
operation that would return ENOTEMPTY? If
broulik added a reviewer: sitter.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15871
To: madcatx, elvisangelaccio, sitter
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.
REVISION SUMMARY
ENOEMPTY return code may be a valid return code from i.e.
