This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R120:17380886d9b8: [Devicenotifications Engine] Keep at most
one notification per UDI (authored by bruns).
CHANGED PRIOR TO COMMIT
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
device_notifier_qml_fix2
REVISION DETAIL
https://phabricator.kde.org/D15892
To: bruns, #frameworks, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot,
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> broulik wrote in devicenotificationsengine.cpp:39
> This potentially breaks applets relying on the structure of that name? Not
> sure how big of an issue this is as far as "API promise" we give for
>
broulik added a comment.
I think this makes sense
INLINE COMMENTS
> devicenotificationsengine.cpp:39
> {
> -const QString source = QStringLiteral("notification %1").arg(m_id++);
> +const QString source = QStringLiteral("%1 notification").arg(udi);
>
This potentially breaks
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
Each notification was created as new datasource, and was newer removed
as long as the engine