This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b71e10359725: Implement wl_surface::damage_buffer
(authored by romangg).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D15910?vs=48477&id=57749#toc
REPOSITORY
R127 KWayland
CHANGES SINCE LA
romangg added a comment.
Will be pushed after 5.56 branched off.
REPOSITORY
R127 KWayland
BRANCH
damageBuffer
REVISION DETAIL
https://phabricator.kde.org/D15910
To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
damageBuffer
REVISION DETAIL
https://phabricator.kde.org/D15910
To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bru
zzag added a comment.
Is it good now?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15910
To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
romangg updated this revision to Diff 48477.
romangg marked an inline comment as done.
romangg added a comment.
- Rebase on master
- Flipped 270 fix
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15910?vs=42764&id=48477
BRANCH
damageBuffer
REVISION D
davidedmundson added inline comments.
INLINE COMMENTS
> surface_interface.cpp:453
> +if (tr == Tr::Rotated90 || tr == Tr::Rotated270 ||
> +tr == Tr::Flipped90 || tr == Tr::Rotated270) {
> +// calculate transformed + scaled bu
romangg added a comment.
Ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D15910
To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
romangg updated this revision to Diff 42764.
romangg marked 3 inline comments as done.
romangg added a comment.
- Remove rects call
- Respect buffer scale
- Test damage against scaled surface
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15910?vs=4276
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in surface_interface.cpp:450
> scale is also a transform.
>
> Note also that the damage signal is used in kwin assuming it's surface local.
Thanks! After applying the output transform **and** the scale transform, the
damaged
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> surface_interface.cpp:450
> +typedef OutputInterface::Transform Tr;
> +const Tr tr = target->transform;
zzag added inline comments.
INLINE COMMENTS
> surface.cpp:244
> +{
> +for (const QRect &r : region.rects()) {
> +damageBuffer(r);
`for (const QRect &r : region) {`
rects() is obsolete. http://doc.qt.io/qt-5/qregion-obsolete.html#rects
REPOSITORY
R127 KWayland
REVISION DETAIL
h
romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.
REVISION SUMMARY
Missing from our surface handling was the damage_buffer call introduced in
version 4 o
12 matches
Mail list logo
