D15912: Don't silently error if damage is sent before buffer

2018-10-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b4cd89ea4977: Dont silently error if damage is sent 
before buffer (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15912?vs=42820=43108

REVISION DETAIL
  https://phabricator.kde.org/D15912

AFFECTED FILES
  src/server/surface_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns


D15912: Don't silently error if damage is sent before buffer

2018-10-03 Thread Roman Gilg
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  For 5.52.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15912

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns


D15912: Don't silently error if damage is sent before buffer

2018-10-03 Thread David Edmundson
davidedmundson updated this revision to Diff 42820.
davidedmundson added a comment.


  Leave useless code in

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15912?vs=42766=42820

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15912

AFFECTED FILES
  src/server/surface_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns


D15912: Don't silently error if damage is sent before buffer

2018-10-02 Thread Roman Gilg
romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> surface_interface.cpp:461
>  }
> -} else if (!target->buffer && emitChanged) {
> +} else if (!target->buffer) {
>  subSurfaceIsMapped = false;

Unrelated change. Or split the whole case distinction directly up into:

  if (target->buffer) {
  if (!target->damage.isEmpty()) {
  ...
  }
  } else {
  subSurfaceIsMapped = false;
  emit q->unmapped();
  }

Maybe separate patch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15912

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns


D15912: Don't silently error if damage is sent before buffer

2018-10-02 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Firefox sends
  
  wl_surface@37.damage(0, 0, 808, 622)
  wl_surface@37.attach(wl_buffer@34, 0, 0)
  
  Which we silently treat as an error.
  
  There's nothing in the spec to forbid this. The only thing that matters
  is the state on commit. This moves a check there.
  
  CCBUG: 397834

TEST PLAN
  Had a debug in there which was being activated
  Gets firefox slightly further (but not complete)

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15912

AFFECTED FILES
  src/server/surface_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns