D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:31c07fa8d6c7: [Places panel] use more appropriate network 
icon (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15931?vs=42823=42885

REVISION DETAIL
  https://phabricator.kde.org/D15931

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #vdg, nicolasfella, andreaska
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Andreas Kainz
andreaska accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg, nicolasfella, andreaska
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Nicolas Fella
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg, nicolasfella
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment.


  +1
  Oxygen uses a globe for "network-workgroup" and a folder with a cable as 
"folder-network", someone might wanted to have a globe icon here for 
recognizability ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Andrew Crouthamel
acrouthamel added a comment.


  +1 from me, makes sense. I say that as a guy who stares at server racks all 
day.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15931

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The current Breeze icon used for the default Network(`network-workgroup`) is 
not ideal for several reasons:
  
  - It it not clear what it depicts (I was told it's a server rack, but there's 
not enough detail to make this apparent)
  - Even if the visuals were clear, its iconography (a server rack) is not 
familiar to people who are not sysadmins
  
  This patch replaces it with `folder-network`, which yields the following 
improvements:
  
  - This icon includes the "sideways dotted V" imagery that is used in other 
contexts (shared folder emblem, Share menu, which teaches the user its meaning
  - Many other platforms use circular globe or world iconography for their 
network icons. Even though this new icon is not a globe or world, it is 
circular, which helps to re-use some of a user's prior experience on other 
platforms
  - Semantically, `folder-network` is just a more appropriate icon to use for 
this than `network-workgroup`. The item leads to the whole network, not a 
specific workgroup.

TEST PLAN
  New icon shows up in all Places panels for new user accounts, or if you 
delete `~/.local/share/user-places.xbel` in an existing user account
  
  Dolphin Places panel:
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  better-network-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15931

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns