D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-05 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-05 Thread Andres Betts
abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham retitled this revision from "Don't show a emblem for mounted disks, 
only unmounted disks" to "Don't show an emblem for mounted disks, only 
unmounted disks".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham added a comment.


  Sure!
  
  External hard drive:
  F6303952: Device notifier - external hard drive.png 

  
  iPhone
  F6303953: Device notifier - iPhone.png 
  
  (The duplicate entries are caused by 
https://bugs.kde.org/show_bug.cgi?id=383255

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment.


  I think that's a sensible idea. Can you also evaluate the implications for 
Device Notifier?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  #VDG  is finalizing a guideline for the 
use of emblems stating that they should only be used for non-default, uncommon, 
unusual, or unexpected  statuses. This is described in D15897 
.
  
  Accordingly, we should only show an emblem when a disk is unmounted, not when 
it's mounted. Being mounted is the expected status for a disk; being 
unmounted-but-visible-anyway is what's unusual and deserves an emblem.
  
  As an added bonus, this hugely improves the look of the Places panel by 
default.
  
  Closes T9740 

TEST PLAN
  Dolphin Places panel now:
  [image goes here]

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns