D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko added a comment.


  That's weird. I caught it only once and thought that it is because I 
trivially forgot the endl. But now I cannot reproduce it anymore.
  Seems like it should be fine, since we do emit finished signal, which will 
write the 'OK' part.
  Sorry for the noise.

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns added a comment.


  Also, is your running baloo_file using current master? Otherwise, it may 
return a file finished long ago, see D15994 
.

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns added a comment.


  In D15985#341854 , @poboiko wrote:
  
  >   Indexing /some/file1Indexing /some/file2: OK
  >
  
  
  Are you sure its file1...file2 and not the same file twice? If it is the 
same, we can set m_currentFile in 71 and suppress the duplicated output in 
startedIndexingFile.

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns added a comment.


  In D15985#341854 , @poboiko wrote:
  
  > In D15985#341811 , @bruns wrote:
  >
  > > No, definitely not, see D15995 .
  >
  >
  > I don't see how it is a problem. The problem is not that it's not written 
to terminal (it is), but that it just doesn't have a trailing newline, i.e. 
output looks like
  >
  >   Indexing /some/file1Indexing /some/file2: OK
  >   Indexing /some/file3: OK
  >   ...
  >
  
  
  So apparently the indexer has not yet processed the registration request and 
does not send us a finished signal?
  
  Can you try to find out the exact sequence of messages using `dbus-monitor 
interface='org.kde.fileindexer'`?

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko added a comment.


  In D15985#341811 , @bruns wrote:
  
  > No, definitely not, see D15995 .
  
  
  I don't see how it is a problem. The problem is not that it's not written to 
terminal (it is), but that it just doesn't have a trailing newline, i.e. output 
looks like
  
Indexing /some/file1Indexing /some/file2: OK
Indexing /some/file3: OK
...
  
  A flush shouldn't hurt.
  
  Just in case, I suggest not to do it inside `startedIndexingFile`, but right 
here, after line 73 (that's because we have a special case of 
`startedIndexingFile` without `finsihedIndexingFile`).

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns added a comment.


  In D15985#341751 , @poboiko wrote:
  
  > Woops! `startedIndexingFile` does not print a newline. I guess I can just 
add `m_out << endl`...
  
  
  No, definitely not, see D15995 .

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko added a comment.


  Woops! `startedIndexingFile` does not print a newline. I guess I can just add 
`m_out << endl`...

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Fantastic! Works great.

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: ngraham, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Looks sane ...

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

To: poboiko, #baloo, #frameworks, bruns
Cc: bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  This is based on D15943: [balooctl] Monitor also for state changes 
.
  Simply print current state & file when monitor starts.
  
  BUG: 364858
  FIXED-IN: 5.52

TEST PLAN
  `balooctl monitor` now prints
  
Press ctrl+c to stop monitoring
File indexer is running
Idle

BRANCH
  monitor-initial-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15985

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp

To: poboiko, #baloo, #frameworks