D16001: ktextedit: lazy load the QTextToSpeech object

2018-10-07 Thread Pino Toscano 
pino closed this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D16001

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16001: ktextedit: lazy load the QTextToSpeech object

2018-10-07 Thread Laurent Montel 
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  lazy-qtexttospeech (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16001

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16001: ktextedit: lazy load the QTextToSpeech object

2018-10-07 Thread Pino Toscano 
pino created this revision.
pino added a reviewer: mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pino requested review of this revision.

REVISION SUMMARY
  Create the QTextToSpeech object on demand, i.e. only at the first
  request to speak a text. While this will make the the first request
  slower (but only the first), the creation of each KTextEdit widget is
  faster again.

TEST PLAN
  Builds fine, unit tests runs fine, ktextedittest still works as
  expected.

REPOSITORY
  R310 KTextWidgets

BRANCH
  lazy-qtexttospeech (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16001

AFFECTED FILES
  src/widgets/ktextedit.cpp

To: pino, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns