D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:db4aac4b6317: [Extractor] Handle documents correctly 
where mimetype should not be indexed (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16236?vs=43702=44219

REVISION DETAIL
  https://phabricator.kde.org/D16236

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this seems to work well.

INLINE COMMENTS

> app.cpp:133
> +if (!m_config.shouldBeIndexed(url)) {
>  // FIXME: This should never be happening!
> +qCWarning(BALOO) << "Found" << url << "in the ContentIndexingDB, 
> although it should be skipped";

Is this FIXME still in need of fixing with your changes here?

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16236

To: bruns, #baloo, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

bruns edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16236

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16236: [Extractor] Handle documents correctly where mimetype should not be indexed

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The BasicIndexingJob started from the UnindexedFileIndexer only has
  the file extension based mimetype and thus can not determine if a file
  should be indexed.
  
  Remove the document only from the indexingleveldb, otherwise the
  document can not be found e.g. by name or type, and the basic indexer is
  run on the file again on each session start.
  
  This is typical for e.g. xml files, which may come with various file
  extensions based on the application, e.g. XMP sidecar files.

TEST PLAN
  start `balooctl monitor`
  save some metadata to an XMP sidecar file, e.g. from digikam
  -> the file is added to the index and immediately removed again.
  When content indexing is switched off, the file stays in the
  index.
  
  After the change, the file stays in the index.

REPOSITORY
  R293 Baloo

BRANCH
  mimetype_handling

REVISION DETAIL
  https://phabricator.kde.org/D16236

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, #frameworks
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams