D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
This revision was automatically updated to reflect the committed changes. Closed by commit R241:518a7496c5c5: Warn user before copy/move job if the file size exceeds the maximum possible… (authored by shubham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16249?vs=46490=46783#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=46490=46783 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment. This can land now! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment. Awesome, can't wait to have this in! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 46490. shubham added a comment. Change to KF 5.54 Will land it after saturday. This patch actually missed 2 tagging (5.52 and 5.53) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=46235=46490 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment. I agree. Because this contains new strings and we're so close to the 5.53 release, let's land this for Frameworks 5.54 after tagging. @shubham I'm afraid this means you'll now need to change all the instances of `5.53` to `5.54`! I know it's taken a long time, but don't worry, it will be landed soon... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
davidedmundson added a comment. Also +1 from me. However, I would strongly suggest waiting till after Saturday when frameworks is tagged. Then you'll have a month for translators and for some testing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham added a comment. Waiting for green flags. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham added a comment. "transferred" done request @ngraham @dfaure @bruns to give thumbs up again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 46235. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=46174=46235 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
bruns added inline comments. INLINE COMMENTS > bruns wrote in job_error.cpp:1079 > "transeferred" "transeferred"? - not done ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham added a comment. @bruns is it good to go? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 46174. shubham added a comment. @since 5.53 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=45951=46174 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment. Sorry for the extended review time; I've found myself super busy with family stuff during this vacation. :) Please address Elvis' inline comment and then this will look good to me. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since > 5.52 > }; You still need to change `@since 5.52` to `@since 5.53` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham added a comment. @ngraham @bruns do you have any objections? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
elvisangelaccio added inline comments. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since > 5.52 > }; Should be bumped to 5.53 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham added a comment. @bruns @ngraham what's your view on this? Did you tested it out? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 45951. shubham added a comment. - a REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=45470=45951 BRANCH fat REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:1602 > QList::Iterator it = files.begin(); > +const auto fileSystem = > KFileSystemType::fileSystemType(m_globalDest.toString()); > // Is this URL on the skip list ? This is going to slow down copying in the normal case. This check should only be done if the size is too big (i.e. inside the `if` further down). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 45470. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) " to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)". shubham edited the summary of this revision. shubham added a comment. Now patch applies cleanly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44712=45470 BRANCH fat REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham removed a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, elvisangelaccio Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment.
Uh-oh, now the patch doesn't apply for me anymore:
$ arc patch D16249
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16249.
Checking patch src/core/job_error.cpp...
error: while searching for:
case KIO::ERR_CANNOT_CREATE_SLAVE:
result = i18n("Unable to create io-slave. %1", errorText);
break;
default:
result = i18n("Unknown error code %1\n%2\nPlease send a full bug
report at https://bugs.kde.org.;, errorCode, errorText);
break;
}
error: patch failed: src/core/job_error.cpp:245
Hunk #2 succeeded at 1068 (offset -4 lines).
Checking patch src/core/global.h...
Checking patch src/core/copyjob.cpp...
Applying patch src/core/job_error.cpp with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Applied patch src/core/global.h cleanly.
Applied patch src/core/copyjob.cpp cleanly.
Patch Failed!
Usage Exception: Unable to apply patch!
Might need to be re-based on the current state of master. But you really
should look into using `arc`; it makes all of this so much easier. Setting it
up takes all of 5 minutes. See
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, elvisangelaccio, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 44712. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44710=44712 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
ngraham added a comment. Uh-oh, I think the latest update to this diff isn't quite correct. I see unrelated changes that you didn't make being marked as additions. You might try using `arc` in the future. It makes this process much simpler. See https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) " to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) ". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
