D16301: Remove ComponentInstaller
This revision was automatically updated to reflect the committed changes. Closed by commit R242:38098e96e3d8: Remove ComponentInstaller (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16301?vs=43874=45796 REVISION DETAIL https://phabricator.kde.org/D16301 AFFECTED FILES autotests/CMakeLists.txt src/plasma/CMakeLists.txt src/plasma/private/componentinstaller.cpp src/plasma/private/componentinstaller_p.h src/plasma/private/dataenginemanager.cpp src/plasma/scripting/scriptengine.cpp To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
apol added a comment. FWIW my +1 is to removing it. The Appstream assessment is all right but fixing something nobody uses sounds like a waste of time. :P REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
broulik added a comment. > Method InstallPackages Thanks for the insight. In any case, the way the code "works" right now is probably not what we want. It has been unused for years and is unlikely to come back in that form, so we can rm it. If we were to support something like this we need to modernize the architecture using AppStream and what not anyway. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
apol added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
bruns added a comment. https://github.com/hughsie/PackageKit/blob/master/src/org.freedesktop.PackageKit.Transaction.xml Method InstallPackages This requires of course we already have a valid package name. For this we probably have to rely on appstream, but need to define an appropriate id first. e.g. org.kde.plasma.dataengine.time org.kde.plasma Time Dataengine REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: bruns, kde-frameworks-devel, michaelh, ngraham
D16301: Remove ComponentInstaller
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute plasmoid infrastructure these days and didn't work. TEST PLAN The interface didn't exist here, and I couldn't find it in the docs, and it's ancient anyway. Even if it worked, it would still fail to load the engine, have you install it (assuming it even finds it), and then you have to restart plasma to load it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 AFFECTED FILES autotests/CMakeLists.txt src/plasma/CMakeLists.txt src/plasma/private/componentinstaller.cpp src/plasma/private/componentinstaller_p.h src/plasma/private/dataenginemanager.cpp src/plasma/scripting/scriptengine.cpp To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
