D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2e3dafe5a892: [Codecs] Remove unneeded const_cast 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16306?vs=43898&id=43910

REVISION DETAIL
  https://phabricator.kde.org/D16306

AFFECTED FILES
  src/codecs/postingcodec.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  oob

REVISION DETAIL
  https://phabricator.kde.org/D16306

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16306: [Codecs] Remove unneeded const_cast

2018-10-18 Thread Laurent Montel 
mlaurent added a reviewer: dfaure.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16306

To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16306: [Codecs] Remove unneeded const_cast

2018-10-18 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QByteArray accepts a const char* in the constructor, no need to cast
  the const away.
  Also make it obvious we are using the const overload of data() by
  replacing it with constData().

REPOSITORY
  R293 Baloo

BRANCH
  oob

REVISION DETAIL
  https://phabricator.kde.org/D16306

AFFECTED FILES
  src/codecs/postingcodec.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams