D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-12 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d338c398aa87: Expose 
KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View (authored 
by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16347?vs=47389=47475#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16347?vs=47389=47475

REVISION DETAIL
  https://phabricator.kde.org/D16347

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/utils/ktexteditor.cpp

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-12 Thread Christoph Cullmann 
cullmann added a comment.


  Hmm, actually, not sure if we need to make it virtual, on the other side, it 
avoids to maintain the redirection.
  I can add a KF6 todo and push it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good.
  
  Unfortunately the context is missing: Does it nake sense to have a // TODO 
KF6: make virtual? Or is that the old way?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann 
cullmann added a comment.


  My change is BC and should have right naming, Dominik, ok?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann 
cullmann updated this revision to Diff 47389.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16347?vs=44008=47389

REVISION DETAIL
  https://phabricator.kde.org/D16347

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/utils/ktexteditor.cpp

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-12-11 Thread Christoph Cullmann 
cullmann commandeered this revision.
cullmann edited reviewers, added: demsking; removed: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: cullmann, mlaurent, vkrause, dhaumann, demsking
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-28 Thread Friedrich W. H. Kossebau 
kossebau resigned from this revision.
kossebau added a comment.


  Not my domain, so resigning as reviewer :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, mlaurent, vkrause, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-22 Thread Christoph Cullmann 
cullmann added a comment.


  Ah, sorry, BC meant "binary compatible", see e.g. 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B
  
  For the linking, on first glance, the change looks ok and should link.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, kossebau, mlaurent, vkrause, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D . 
demsking added a comment.


  Thanks @cullmann for your review. 
  Just one question: what do you mean about **BE**. I'm not a native so I'm not 
sure what it mean.
  
  I tried to do that without virtual function like `setScrollPosition()` but 
there is a linking issue when trying to compile an external application with 
the generated **libKF5KTextEditor.so**:
  `undefined reference to 
KTextEditor::View::setInputMode(KTextEditor::View::InputMode)`

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, kossebau, mlaurent, vkrause, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Christoph Cullmann 
cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, kossebau, mlaurent, vkrause, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Christoph Cullmann 
cullmann added a comment.


  I think having API for this is good, but it must be done without a virtual 
function, that is not BC.
  
  See e.g. setScrollPosition for how to do that.
  One could add a KF6 TODO to make it virtual.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, kossebau, mlaurent, vkrause, dhaumann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D . 
demsking added a reviewer: dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

To: demsking, kossebau, mlaurent, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

2018-10-21 Thread Sébastien D . 
demsking created this revision.
demsking added reviewers: kossebau, mlaurent, vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
demsking requested review of this revision.

REVISION SUMMARY
  This makes possible to change the View Input Mode using 
`KTextEditor::View:setInputMode(InputMode)`.
  This is useful for when using *KTextEditor* as an external library in an 
another project. The developer should be able to change the input mode 
programmatically.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16347

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/view/kateview.h

To: demsking, kossebau, mlaurent, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann